This repository was archived by the owner on Jan 22, 2024. It is now read-only.
Conversation
keefertaylor
changed the title
keefertaylor
requested review from
amiecorso,
sarahkevinking and
tedkalaw
as code owners
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
- Coverage 92.46% 85.87% -6.60%
==========================================
Files 11 11
Lines 677 729 +52
Branches 160 173 +13
==========================================
Hits 626 626
- Misses 26 78 +52
Partials 25 25
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Serialize transaction specific data for all functions now that serialization for these protocol buffers are implemented.
Context of Change
Note that this change is just hooking up protocol buffers.
The protocol buffer library ensures (via a
oneof) that if:then
For that reason, lots of lines in this PR are not tested because they are a logical fallacy based on the sanity checks provided by generated protocol buffer code.
Also note that all transaction data cases are not hit because we know:
bar, serializes correctly (via unit tests forbarToJSON)Type of Change
Before / After
After this change, we can serialize all specific transaction data. Note that some common fields, such as
signersare still not serialized. That functionality is coming in #519.Also note there are several TODOs in this class which will get cleaned up as a final task for this functionality.
Test Plan
CI shows that this does not affect existing behavior. Rational for not providing additional unit tests is provided above.